Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add phone field and children #26

Merged
merged 7 commits into from
Jan 26, 2024
Merged

add phone field and children #26

merged 7 commits into from
Jan 26, 2024
+205 −4

Conversation

isybuy
Copy link
Contributor

@isybuy isybuy commented Jan 24, 2024

Add Phone Field and its children according to https://xml.cxml.org/current/cXMLReferenceGuide.pdf instead of just a string, because in my case with amazon business punch out system it wasn't compatible 😢

<Phone name="personal">
    <TelephoneNumber>
        <CountryCode isoCountryCode="US">1</CountryCode>
        <AreaOrCityCode>800</AreaOrCityCode>
        <Number>5551212</Number>
    </TelephoneNumber>
</Phone>

@ynnoig ynnoig requested review from ynnoig and mathielen January 24, 2024 13:40
@ynnoig ynnoig added the enhancement New feature or request label Jan 24, 2024
@ynnoig ynnoig linked an issue Jan 24, 2024 that may be closed by this pull request
add Phone and children #25
Closed
@ynnoig
Copy link
Member

ynnoig commented Jan 24, 2024

@isybuy can u please rebase your branch? We had some style problems and it was resolved today and now we have a conflict in the PR. Thanks in advance

@isybuy
Copy link
Contributor Author

isybuy commented Jan 24, 2024

i did it, is it good enough ?

@ynnoig
Copy link
Member

ynnoig commented Jan 25, 2024 •
edited
Loading

@isybuy phpstan error.
Can u please fix it?

i,.e. -> https://github.com/FriendsOfCXML/cxml-php/actions/runs/7642665010/job/20851360177?pr=26

@mathielen mathielen merged commit 77a13a1 into FriendsOfCXML:main Jan 26, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ynnoig ynnoig Awaiting requested review from ynnoig

@mathielen mathielen Awaiting requested review from mathielen

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add Phone and children
3 participants
@isybuy @ynnoig @mathielen